Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track.GetInfoAsync does not return "userplaycount" #111

Closed
roflmuffin opened this issue Mar 28, 2018 · 3 comments
Closed

Track.GetInfoAsync does not return "userplaycount" #111

roflmuffin opened this issue Mar 28, 2018 · 3 comments
Labels
Milestone

Comments

@roflmuffin
Copy link

It looks like if you pass a username to the GetInfoAsync method, the number of plays returned is the total plays, regardless of the username provided.

When you hit this API outside of the client, there are two properties, "playcount" (the one returning from the API), and one called "userplaycount".

Should we add this value to the track info, or modify it to be the user play count when providing a username?

@rikkit
Copy link
Member

rikkit commented Mar 28, 2018

Hi @roflmuffin, thanks for creating the issue. I would be in favour of providing both bits of information if possible, i.e. two properties on the track object where UserPlayCount is null if not available on the API response.

I really need to get #107 sorted before any released can be made for this package, but if you would like to send a PR to fix this issue I'll be sure to get that reviewed and merged in!

@rikkit rikkit added the api label Mar 28, 2018
@rikkit rikkit added this to the 1.1 milestone Mar 28, 2018
@SHOEGAZEssb
Copy link
Contributor

This was fixed by #116

@rikkit rikkit modified the milestone: 1.1 Jul 1, 2018
@rikkit
Copy link
Member

rikkit commented Jul 2, 2018

@roflmuffin This is now released in the 1.1.0 package. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants