Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to enable/disable an alert node config #3292

Closed
3 tasks
russorat opened this issue Apr 23, 2018 · 4 comments
Closed
3 tasks

add the ability to enable/disable an alert node config #3292

russorat opened this issue Apr 23, 2018 · 4 comments

Comments

@russorat
Copy link
Contributor

russorat commented Apr 23, 2018

Right now, there is no way to "unset" an alert node config in the Kapacitor UI. We should add that ability.

  • determine if we can toggle enable/disable for kapa configs
  • add the option to enable / disable to the ui.
  • ensure we can use this to remove the deprecated notice in the UI
@russorat
Copy link
Contributor Author

required for #2786 and #2904

@russorat russorat changed the title add the ability to delete an alert node config add the ability to enable/disable an alert node config Apr 30, 2018
@alexpaxton
Copy link
Contributor

screen shot 2018-05-03 at 9 32 01 am

Use a ConfirmButton here to prevent accidental resets. Using the language "Reset" because all this should do is set all the values back to an unconfigured state, rather than deleting anything. This action should remove the green checkmark in the alert tab as well, which will indicate to the user that the action was effective

@alexpaxton alexpaxton removed the design label May 3, 2018
@alexpaxton alexpaxton removed their assignment May 3, 2018
@alexpaxton
Copy link
Contributor

Also, the use case of disabling doesn't make a ton of sense to me. Not sure why someone would want to turn off a config but preserve the values (which is what "disable" means to me) and then re-enable later

@alexpaxton
Copy link
Contributor

Final Design

screen shot 2018-05-03 at 2 16 32 pm

Notes:

  • The green checkmark icon represents enabled state, the absence of a checkmark means the configuration is disabled
  • Saving a configuration enables it (unchecks the checkbox)
  • Checking the checkbox disables and saves the values
  • Clicking delete removes the config and is only available when you have multiple configs for the same endpoint (Slack)

@russorat russorat changed the title add the ability to enable/disable an alert node config add the ability to enable/disable/delet an alert node config May 7, 2018
@russorat russorat changed the title add the ability to enable/disable/delet an alert node config add the ability to enable/disablean alert node config May 7, 2018
@russorat russorat changed the title add the ability to enable/disablean alert node config add the ability to enable/disable an alert node config May 7, 2018
@bthesorceror bthesorceror self-assigned this May 8, 2018
@russorat russorat added this to the 1.5.0 milestone May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants