Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compiler package to use optimized Value struct #3992

Closed
jsternberg opened this issue Aug 23, 2021 · 1 comment
Closed

Refactor compiler package to use optimized Value struct #3992

jsternberg opened this issue Aug 23, 2021 · 1 comment
Assignees

Comments

@jsternberg
Copy link
Contributor

jsternberg commented Aug 23, 2021

We are going to refactor the compiler package to use an optimized Value struct as detailed in this proposal. Instead of refactoring the Value interface, we will be creating a new Value struct in the compiler package and modifying the compiler package to use this instead of values.Value.

Note: This should be done through copying the package into a new package below internal. We then want to feature flag the use of this new compiler in areas where the old compiler is used.

DOD:

  • A refactored compiler exists that uses a Value struct as described in the above proposal.
  • It is behind a feature flag (either scoped to map or the compiler)
  • Tests should be testing with the flag on and off
@jsternberg jsternberg self-assigned this Nov 15, 2021
@jsternberg jsternberg added this to the Sprint 21-Q4-4 milestone Nov 15, 2021
@jsternberg
Copy link
Contributor Author

Not going to be done. We're more likely to completely replace the compiler package with an alternative so this issue won't get done.

@jsternberg jsternberg closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant