Add sideload node and service #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
desa
suggested changes
Oct 26, 2017
sideload.go
Outdated
| bufferPool *bufpool.Pool | ||
| } | ||
|
|
||
| // Create a new SideloadNode which shifts points and batches in time. |
There was a problem hiding this comment.
which shifts points and batches in time.
Is this right?
sideload.go
Outdated
| order: make([]string, len(n.OrderList)), | ||
| orderTmpls: make([]orderTmpl, len(n.OrderList)), | ||
| } | ||
| u, err := url.Parse(n.Source) |
There was a problem hiding this comment.
Should lines 40-49 go into the et.tm.SideloadService.Source method?
There was a problem hiding this comment.
Yeah, that would make more sense.
| } | ||
| n.order[i] = p | ||
| } | ||
| if len(n.s.Fields) > 0 { |
There was a problem hiding this comment.
Sucks that the logic for fields and tags can't be pulled into a common method without adding reflection.
desa
approved these changes
Oct 27, 2017
nathanielc
force-pushed
the
nc-sideload
branch
from
aac1a45 to
3499cfe
Compare
goller
approved these changes
Nov 8, 2017
nathanielc
changed the title
nathanielc
force-pushed
the
nc-sideload
branch
from
3499cfe to
216b381
Compare
nathanielc
added a commit
that referenced
this pull request
Nov 8, 2017
Add sideload node and service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sideload node that acts similar to the default node but allows the data to be loaded from external sources.
TODO
{tag}syntax.