Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kapacitor and InfluxDB should have similar HTTPS Configuration #1690

Closed
desa opened this issue Nov 21, 2017 · 6 comments
Closed

Kapacitor and InfluxDB should have similar HTTPS Configuration #1690

desa opened this issue Nov 21, 2017 · 6 comments

Comments

@desa
Copy link
Contributor

desa commented Nov 21, 2017

Kapacitor doesn't split out cert and key as separate files

if s.https {
cert, err := tls.LoadX509KeyPair(s.cert, s.cert)
if err != nil {
return err
}

	if s.https {
		cert, err := tls.LoadX509KeyPair(s.cert, s.cert)
		if err != nil {
			return err
		}

Telegraf, InfluxDB, and Chronograf have them as separate https-cert and https-key

InfluxDB:
https://github.com/influxdata/influxdb/blob/e9cbc6da11435fd690561ff82e4a367ebdc62c79/services/httpd/service.go#L93-L97

	if s.https {
		cert, err := tls.LoadX509KeyPair(s.cert, s.key)
		if err != nil {
			return err
		}

Either Kapacitor should switch to using the same convention of the rest of TICK, or TIC should change to Kapacitor's convention.

@desa
Copy link
Contributor Author

desa commented Nov 21, 2017

@nathanielc thoughts on this issue?

@nathanielc
Copy link
Contributor

@desa When did this change for InfluxDB? The Kapacitor TLS code was copied verbatim from InfluxDB.

I think having them split makes more sense. Can we split them now and still have backwards compatible config?

@nathanielc
Copy link
Contributor

Looks like we just need to apply this patch to the Kapacitor code. influxdata/influxdb@5d9eae6

@desa
Copy link
Contributor Author

desa commented Nov 21, 2017

@desa
Copy link
Contributor Author

desa commented Nov 21, 2017

👍

@rbetts rbetts added this to the 1.5.0 milestone Dec 7, 2017
@rbetts rbetts removed the pm/review label Dec 7, 2017
@AdamSLevy
Copy link

This will be very nice to have fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants