Add multiple field support to change detect #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
nc-change-detect
branch
3 times, most recently
from
a2b2ec1 to
684ed75
Compare
desa
approved these changes
Nov 21, 2018
| for _, field := range n.d.Fields { | ||
| value, ok := curr[field] | ||
| if !ok { | ||
| n.diag.Error("Invalid field in change detect", |
There was a problem hiding this comment.
Do you think that this might be a bit noisy? I'm imagining a case where you want to change detect on field_a or field_b, but 90% of the contains data that is written is for only field_a. Wont this create a log for every point that comes through (provided that there is no change detected each time?
There was a problem hiding this comment.
Good question. All nodes now have the .quiet option to tell them to not log anything. So I think it if fine to leave as the default then in that special case the user can explicitly quite the specific changeDetect node.
nathanielc
force-pushed
the
nc-change-detect
branch
from
684ed75 to
ec22ea9
Compare
nathanielc
added a commit
that referenced
this pull request
Nov 21, 2018
Add multiple field support to change detect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also updates to Go 1.11 and runs
go fmt ./...