Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on groupby #236

Closed
yosiat opened this issue Feb 15, 2016 · 4 comments
Closed

Panic on groupby #236

yosiat opened this issue Feb 15, 2016 · 4 comments
Milestone

Comments

@yosiat
Copy link
Contributor

yosiat commented Feb 15, 2016

Hi,
I got panic while I used groupBy in my tick script.

I don't think this is a good strategy for not implemented features, I think it should be an error that will be logged.
For fixing this I needed for remove my Kapacitor data folder and only then my service got up.

@nathanielc nathanielc added this to the v0.11 milestone Feb 16, 2016
@nathanielc
Copy link
Contributor

Can you post the panic stack trace?

@yosiat
Copy link
Contributor Author

yosiat commented Feb 16, 2016

The panic is from here, on the default case -

https://github.com/influxdata/kapacitor/blob/master/group_by.go

@nathanielc
Copy link
Contributor

Perfect thanks, Agreed since it makes it hard to restart Kapacitor I will change the error behavior.

@yosiat
Copy link
Contributor Author

yosiat commented Feb 16, 2016

I think it should be validation on the "wants" and "provides" of each node.

If I am connecting window node to group node, on the define request I should get errors the window provides batch and group wants stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants