Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types of alerts triggered in dot/execution stats #419

Closed
yosiat opened this issue Apr 5, 2016 · 3 comments
Closed

Add types of alerts triggered in dot/execution stats #419

yosiat opened this issue Apr 5, 2016 · 3 comments

Comments

@yosiat
Copy link
Contributor

yosiat commented Apr 5, 2016

Hi,

Currently the AlertNode exposes alerts_triggered stats, I think it will be nice to add:

  • Count by severity: { "info": 129, "warn": 12, "crit" : 0 }
  • Last alert triggered time and it's severity

What do you think? I can submit a PR if you like this idea.

@nathanielc
Copy link
Contributor

+1 on stats by severity.

The last alert time feels like overkill as a statistic. What is the use case for last alert time? Do you care about last alert time by group or just overall for the node? Seems related to this request too #388

@yosiat
Copy link
Contributor Author

yosiat commented Apr 5, 2016

We have alerts that goes on windows that emits every 2 hour or longer, we would like to see the last severity popped out for this alert.

And yes, we care about the group.. but when I think about it this will be overkill =X

@yosiat
Copy link
Contributor Author

yosiat commented Apr 5, 2016

@nathanielc so I can go on and implements stats by severity? this is a simple expvar.Map ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants