-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alert with stateChangesOnly doesn't trigger OK on script start #744
Comments
@phemmer I think the correct solution is to store the alert state in a persistent manner instead of loosing it on process restart or task restart. But that is a lot of work, and while it is on the roadmap, it is a ways out. I like the idea of triggering an OK on start. This will only work though if Kapacitor receives new data. For example say host A goes CRITICAL and then kapacitor stops and host A recovers. When Kapacitor starts back up it will not know that host A exists until it receives the first point from host A. At that point it could fire an OK alert but not before, (for the same reason that all state is lost during a restart). Will that still work for your current needs? |
The only reason why I didn't mention the persistence is that it won't solve scenario 2. If the script is changed, what is your persistence key going to be? Meaning how will you know which alert needs an OK to be sent? But anyway, I think having to wait for data before sending an OK is reasonable. That is in fact what I would expect. |
It states this ticket is closed but what is the fix for this issue? We have noted similar behavior to this issue with the deadman node issuing a flurry of fals positive alerts upon Kapacitor restart |
There are 2 related scenarios here.
stateChangesOnly
enabled, and kapacitor has triggered a CRITICAL alert. But then you stop the script, or kapacitor, or the whole host it's running on. While the script is stopped the condition clears. When kapacitor starts back up, it doesn't send an OK alert, and so any external systems still see the state as CRITICAL.stateChangesOnly
enabled, but you have a bad tick script which results in some erroneous alerts. So you fix the script and then redefine it in kapacitor. When the new script is started, it comes up in OK state, but an OK alert doesn't get triggered. An alert gets triggered if it's still in an INFO, WARNING, or CRITICAL state, just not OK. This results in the false alerts not getting cleared.I think it would be a good idea to allow triggering an OK alert when a script first starts up.
The text was updated successfully, but these errors were encountered: