Add auth token to OpenTSDB

[RemyTinco]

Feature Request

Allow HTTP(S) basic auth in OpenTSDB connection.

Proposal:

Current behavior:

[[outputs.opentsdb]]
        host = "http://opentsdb-gra1.tsaas.ovh.com"

Desired behavior:

[[outputs.opentsdb]]
        host = "http://opentsdb-gra1.tsaas.ovh.com"
        tokenId = "foo",
        tokenKey = "bar"

Use case: [Why is this important (helps with prioritizing requests)]

I'm using OVH PaaS for monitoring. We must use token ...
Actually, you can find an example here : https://github.com/runabove/iot-push-examples/blob/master/Golang/go-client.go

[cambierr]

To get this more general I suggest using username instead of tokenId and password instead of tokenKey.

[mirath]

Doesn't #1913 close this?

[danielnelson]

Thanks for pointing out this related issue @mirath. It looks to me like that PR does not actually add basic auth support as titled, but instead allows passing through the userinfo section of the url.

[mirath]

I looked at the changes and it looks that, for an url formated as https://<user>:<pass>@example.com/, it passes <user>:<pass> as a string to whatever it creates the HTTP/HTTPS connection. If that is the case wouldn't that allow to connect to OpenTSDB using basic auth?

[danielnelson]

Basic auth uses the Authorization header and base64 encodes the user:password.

[reimda]

Since the username and password is passed through to the connection, it appears that #1913 does fix this. Closing