Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TLS DNS name allowed lists #9272

Closed
isodude opened this issue May 14, 2021 · 4 comments · Fixed by #9910
Closed

Add support for TLS DNS name allowed lists #9272

isodude opened this issue May 14, 2021 · 4 comments · Fixed by #9910
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@isodude
Copy link
Contributor

isodude commented May 14, 2021

Feature Request

Support for allowing only a certain list of dns names or fingerprints in client certificates

Proposal:

Current behavior:

Only filtering with CA is possible

Desired behavior:

Possible to define
tls_allowed_dns_names = [""]
tls_allowed_fingerprints = [""]

Such that only defines names or fingerprints is allowed to connect to telegraf

Use case:

Locking down access to telegraf even though the CA is shared along with other purposes.
DNS Names allow for a more dynamic approach which fingerprints allow to really pin the certificate down to exactly one.

The code is complete and I can make a PR with it.

@isodude isodude added the feature request Requests for new plugin and for new features to existing plugins label May 14, 2021
@isodude
Copy link
Contributor Author

isodude commented May 21, 2021

Code can be viewed here: https://github.com/isodude/telegraf/tree/tls

@akrantz01
Copy link
Contributor

Thanks for looking into this. Please make a PR, so your changes are easier to find.

@isodude
Copy link
Contributor Author

isodude commented Aug 31, 2021

Sure, I'll try to make some tests along with it.

@isodude
Copy link
Contributor Author

isodude commented Sep 27, 2021

Not forgetting about this, just.. redoing a lot internally.

Setting up an ACME server makes the fingerprint list kind of not needed. DNS-names however is quite handy.

@isodude isodude changed the title Add support for TLS DNS name and fingerprint allowed lists Add support for TLS DNS name allowed lists Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants