Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry_for_client_errors option to outputs.http plugin #9646

Closed
mzbroch opened this issue Aug 18, 2021 · 5 comments
Closed

Add retry_for_client_errors option to outputs.http plugin #9646

mzbroch opened this issue Aug 18, 2021 · 5 comments
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@mzbroch
Copy link

mzbroch commented Aug 18, 2021

Feature Request

Proposal:

Add retry_for_client_errors option to outputs.http plugin

Current behavior:

Telegraf's outputs.http plugin retries writing the metric in case of 4xx errors. No configurable parameters exist to control this current behaviour.

Desired behavior:

outputs.http plugin in Telegraf understands client side error codes and can optionally not retry (drop the metrics) in case of 4xx errors.

Use case:

@mzbroch mzbroch added the feature request Requests for new plugin and for new features to existing plugins label Aug 18, 2021
@dgarros
Copy link

dgarros commented Aug 27, 2021

Our team would be happy to send a PR to add this flag but it would be helpful to understand if this would be accepted first.

@rabenhorst
Copy link

WDYT about adding a client_errors_ignore_list option that takes an array of 4xx status codes so you can flexible configure which error codes should be ignored in the output (i.e. return no error).

@mzbroch
Copy link
Author

mzbroch commented Nov 25, 2021

It sounds reasonable, does this mean we're making a project decision about this issue?

@nvinzens
Copy link
Contributor

nvinzens commented Nov 26, 2021

Opened a PR for that in #10186, happy to change the naming if peeps don't agree with non_retryable_statuscodes.

@DStrand1
Copy link
Member

Closed by #10186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

5 participants