Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on v0.34.x branch #14

Closed
conorsch opened this issue Aug 15, 2023 · 2 comments
Closed

Build error on v0.34.x branch #14

conorsch opened this issue Aug 15, 2023 · 2 comments

Comments

@conorsch
Copy link

When I try to build the binary on the v0.34.x branch, I encounter an error:

❯ go install ./cometmock/
# github.com/informalsystems/CometMock/cometmock/abci_client
cometmock/abci_client/client.go:288:106: block.Evidence.Evidence.ToABCI undefined (type "github.com/cometbft/cometbft/types".EvidenceList has no field or method ToABCI)
cometmock/abci_client/client.go:311:118: undefined: abcitypes.Misbehavior
cometmock/abci_client/client.go:711:11: assignment mismatch: 1 variable but a.CurState.MakeBlock returns 2 values

It appears this was introduced by 73bdb02 ; if I revert just that commit, then I'm able to build again.

Builds on main and v0.37.x work just fine, no problems there.

@p-offtermatt
Copy link
Member

p-offtermatt commented Aug 16, 2023

Thank you for reporting the issue!
This has been fixed in https://github.com/informalsystems/CometMock/tree/aa1a91e6b29164bcbff6efdd532c26246afcbf23. Sorry for the inconvenience.

The automated testing for CometMock itself is not quite sufficient and this is something I do need to fix; related issue #16

@conorsch
Copy link
Author

Beautiful, thanks for the quick triage. I can confirm I can build again on the v0.34.x branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants