Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer multiple rpc servers to direct calls to different apps #69

Open
p-offtermatt opened this issue Oct 9, 2023 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers prio:mighthave For low priority issues that might be nice to have, but are not particularly important.

Comments

@p-offtermatt
Copy link
Member

Is your feature request related to a problem? Please describe.
When e.g. calling the status endpoint https://docs.cometbft.com/v0.34/rpc/#/Info/status,
currently CometMock just uses the first validator and prints information for it.
This means it is hard to actually get information for other validators.

Describe the solution you'd like
CometMock should offer a way to direct calls to other apps/make them look like they hit a specific validator.

One solution for this could be to offer several addresses that cometmock listens on as an rpc server.
Which address a call gets directed to determines which validator it corresponds to.
The addresses could be specified during startup.

Additional context
This issue is currently low priority, since there are workarounds for the use cases so far - e.g. for getting the node-id, the cosmos-sdk offers functionality to get it without having to go through the cometbft rpc server with

gaiad tendermint show-node-id

If the workarounds become too cumbersome for future issues, this should potentially be addressed.

@p-offtermatt p-offtermatt added enhancement New feature or request good first issue Good for newcomers prio:mighthave For low priority issues that might be nice to have, but are not particularly important. labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers prio:mighthave For low priority issues that might be nice to have, but are not particularly important.
Projects
None yet
Development

No branches or pull requests

1 participant