Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate dependence on (and prepare for changes to) DeliverTX Events and Log #3123

Open
5 tasks
adizere opened this issue Feb 23, 2023 · 0 comments
Open
5 tasks

Investigate dependence on (and prepare for changes to) DeliverTX Events and Log #3123

adizere opened this issue Feb 23, 2023 · 0 comments
Labels
I: dependencies Internal: related to dependencies I: logic Internal: related to the relaying logic O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding

Comments

@adizere
Copy link
Member

adizere commented Feb 23, 2023

Summary

SDK is planning a refactor of DeliverTX responses: cosmos/cosmos-sdk#15017.
I suspect Hermes depends on this surface, see below for example:

hermes/crates/relayer/src/event/rpc.rs

Line 117 in 097c5df

pub fn get_all_events(

Suggested actions: allocate time to

  • engage with the SDK team to inform their new design/refactoring, because any change has the potential to simplify (or break) the relayer
  • prepare for breaking changes
  • inform the design for relayer-next based on the refactoring that the SDK is doing

Problem Definition

Proposal

Acceptance Criteria

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere adizere added I: logic Internal: related to the relaying logic I: dependencies Internal: related to dependencies O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I: dependencies Internal: related to dependencies I: logic Internal: related to the relaying logic O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adizere