Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light client needlessly re-fetch already Trusted blocks from its peer #427

Closed
romac opened this issue Jul 9, 2020 · 0 comments · Fixed by #419
Closed

Light client needlessly re-fetch already Trusted blocks from its peer #427

romac opened this issue Jul 9, 2020 · 0 comments · Fixed by #419
Labels
enhancement New feature or request light-client Issues/features which involve the light client

Comments

@romac
Copy link
Member

romac commented Jul 9, 2020

Moved over from #418

In the light client verification loop, we only look in the store for a block at the current height that is either Verified or Unverified (ie. we fetch it from a node), which may miss a block that has previously gone through fork detection and has been marked as Trusted. We thus have to fetch it again from the peer, which is wasteful.

@romac romac added light-client Issues/features which involve the light client enhancement New feature or request labels Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request light-client Issues/features which involve the light client
Projects
None yet
1 participant