Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-client: clock drift for trusting period #523

Closed
OStevan opened this issue Aug 13, 2020 · 4 comments
Closed

light-client: clock drift for trusting period #523

OStevan opened this issue Aug 13, 2020 · 4 comments
Labels
light-client Issues/features which involve the light client question Further information is requested

Comments

@OStevan
Copy link
Contributor

OStevan commented Aug 13, 2020

When reading the Predicate checks I noticed that there is a conflict with a comment and the code regarding usage of clock drift from #474 . This specifically says we adjust for clock drifts but that parameter is not passed in nor used.

Should we adjust or not in this case? It was already mentioned but currently, with the comment it seems to be confusing.

@xla xla added light-client Issues/features which involve the light client question Further information is requested labels Aug 14, 2020
@Shivani912
Copy link
Contributor

Ay, very good catch! No we're not adjusting for clock drift right now. I think issue #478 contains further discussion on whether we should or not. I'd suggest to update the comment for the current state of code for now and wait for a decision on how to account for clock drifts since it's a larger issue.

@xla xla changed the title Clock drift for trusting period. light-client: clock drift for trusting period Aug 18, 2020
@xla
Copy link
Contributor

xla commented Aug 18, 2020

Can we merge this into #478 then? @OStevan @Shivani912

@Shivani912
Copy link
Contributor

Yeah, I think we should link it there @xla

@ebuchman
Copy link
Member

Lets close this for #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
light-client Issues/features which involve the light client question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants