You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From working on #686 , looks like MBT is wrongly re-arranging validators in validator_setafter Testgen (correctly) generates it. Not sure yet where exactly this is happening. As a temporary solution, I'm re-sorting it locally (in light-client/tests/model_based.rs) to get the correct validator set.
This was caught by comparing the hashes like below from a more detailed output of one of the tests:
"regen val hash" is the hash of validator set that was re-generated from testgen_block of the test using Testgen (testgen_block is a raw, minimal data using which the Testgen produces a LigthBlock)
"current resorted vals hash" is the hash of re-sorted validator set in LightBlock
"header_validators_hash" is the hash of validator set in LightBlock's Header, and
"validators_hash" is the hash of the validator set present in LightBlock
For better understanding, below is what a single MBT test contains:
From working on #686 , looks like MBT is wrongly re-arranging
validators
invalidator_set
after Testgen (correctly) generates it. Not sure yet where exactly this is happening. As a temporary solution, I'm re-sorting it locally (inlight-client/tests/model_based.rs
) to get the correct validator set.This was caught by comparing the hashes like below from a more detailed output of one of the tests:
testgen_block
of the test using Testgen (testgen_block
is a raw, minimal data using which the Testgen produces aLigthBlock
)For better understanding, below is what a single MBT test contains:
tendermint-rs/light-client/tests/model_based.rs
Lines 60 to 67 in 91bc1f6
The text was updated successfully, but these errors were encountered: