Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tendermint config handle optional values + fix net::Address Display #908

Merged

Conversation

tzemanovic
Copy link
Contributor

@tzemanovic tzemanovic commented Jun 16, 2021

closes #906, #907

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@tzemanovic tzemanovic marked this pull request as ready for review June 16, 2021 11:31
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #908 (22d82eb) into master (05da904) will increase coverage by 0.2%.
The diff coverage is 86.0%.

❗ Current head 22d82eb differs from pull request most recent head eacdc2a. Consider uploading reports for the commit eacdc2a to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master    #908     +/-   ##
========================================
+ Coverage    70.5%   70.7%   +0.2%     
========================================
  Files         203     203             
  Lines       16204   16228     +24     
========================================
+ Hits        11424   11477     +53     
+ Misses       4780    4751     -29     
Impacted Files Coverage Δ
tendermint/tests/config.rs 96.1% <77.7%> (-1.2%) ⬇️
tendermint/src/config.rs 65.8% <84.3%> (+5.0%) ⬆️
tendermint/src/net.rs 90.8% <100.0%> (+8.3%) ⬆️
tendermint/src/timeout.rs 83.0% <100.0%> (+13.2%) ⬆️
tendermint/src/trust_threshold.rs 78.9% <0.0%> (-14.9%) ⬇️
tendermint/src/node.rs 65.9% <0.0%> (-0.3%) ⬇️
tendermint/src/hash.rs 36.4% <0.0%> (-0.2%) ⬇️
light-client/src/types.rs 30.6% <0.0%> (ø)
tendermint/src/abci/path.rs 0.0% <0.0%> (ø)
tendermint/src/signature.rs 56.4% <0.0%> (+1.4%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05da904...eacdc2a. Read the comment docs.

Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

For some reason the doc test (which runs on Rust nightly) keeps failing here. I ran the doc tests locally on my machine for this PR, using nightly, and it compiles just fine, so I'm not sure what the problem is.

@thanethomson thanethomson merged commit 795e3bd into informalsystems:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tendermint config optional values parsing
3 participants