Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend display #507

Closed
ameliebernier opened this issue Nov 7, 2019 · 18 comments
Closed

Legend display #507

ameliebernier opened this issue Nov 7, 2019 · 18 comments
Labels
duplicate Duplicate issues // Doublons enhancement New features and improvements // Nouvelles fonctionnalités et améliorations in progress In progress // Développement en cours

Comments

@ameliebernier
Copy link
Contributor

I think that it may not be easy to find a layer's legend. Should we bring back the arrow at the left and keep the interaction with the layer name to expand/close the content? The arrow would show that there is an expandable content. The catalog could have the same behaviour as well as any list element with expandable content.

I know it was a space issue but I think it can be easily overlooked and the user would search for the legend.

@cbourget
Copy link
Collaborator

cbourget commented Nov 7, 2019

Or, we could add a button that toggles all the layers legend at once? This would save the user quite a few clicks if he wants to see the whole legend.

@ameliebernier
Copy link
Contributor Author

At the top? What is this button for
image

@cbourget
Copy link
Collaborator

cbourget commented Nov 7, 2019

I think it's used to show only the layers in range (resolution). Yes, I think I would put it at the top.

@ameliebernier
Copy link
Contributor Author

Is there still a need to see the legend for only one layer? There is a lot going on in this section with the filters, etc.

@cbourget
Copy link
Collaborator

cbourget commented Nov 7, 2019

Personnally, I think we should show all the legend or not show it all but the status quo is acceptable (or, like you suggested, maybe add an arrow icon). It's true that there may not be enough room for another button at the top of the list.

@ameliebernier
Copy link
Contributor Author

Or replace the button to filter the layers in range?

@ameliebernier
Copy link
Contributor Author

I was thinking about the fact that the filters (attributes and time) are now displayed uner the name of the layer, so if you have several filters and then also display the legend of all layers it could be too much

@cbourget
Copy link
Collaborator

cbourget commented Nov 7, 2019

That's a possibility to explore. Adding @pelord to this conversation.

Maybe we shouldn't show the filter input all the time and add a toggle button for it. That would free some room.

@pelord
Copy link
Member

pelord commented Nov 8, 2019

At the top? What is this button for
image

This buttons stands for remove from the layer list the layer not available at the current scale.

Furthermore, this toolbar need to be fixed due to an issue between transition from 0.X version to 1.0.0 version. ( #467 )

About modifying the whole behave of the legend/options/tools , @mbarbeau , @josee666, @gignacnic @danlav01, @VP08 and I identified a way to manage the options/tools. Something like ...

image

At this moment, some free space will allow to propose an alternative method to access the legend.

This new feature is plan in the 1.2 roadmap. ( https://github.com/orgs/infra-geo-ouverte/projects/9 )
Refer to #357

@ameliebernier
Copy link
Contributor Author

Interesting, should the filters appear at the bottom too, instead of under each layer. I think the space under each layer should be reserved for the legend, with a button to expand or collapse them all.

Aussi pour être consistent avec le reste de l'application (catalogue, résultats de recherche), la section du bas devrait-elle s'afficher quand on clique sur un layer?

@pelord
Copy link
Member

pelord commented Nov 8, 2019

Interesting, should the filters appear at the bottom too, instead of under each layer. I think the space under each layer should be reserved for the legend, with a button to expand or collapse them all.

Yes.

@pelord
Copy link
Member

pelord commented Nov 8, 2019

Aussi pour être consistent avec le reste de l'application (catalogue, résultats de recherche), la section du bas devrait-elle s'afficher quand on clique sur un layer?

A envisager.

@ameliebernier
Copy link
Contributor Author

Should we address the legend in version 1.2? It seems to go with #357 and we shouldn't stay too long without

@pelord
Copy link
Member

pelord commented Nov 8, 2019

You should create an issue. A discussion must be done will all contributor because it's look like a roolback to bring back the caret to toggle the legend.

@ameliebernier
Copy link
Contributor Author

This is the issue

@pelord
Copy link
Member

pelord commented Nov 8, 2019

:)

@josee666
Copy link

Pour ce qui est de la légende, de notre coté la configuration active d'ouvrir la légende automatiquement lorsqu'on active la couche semble satisfaisante pour l'instant.
NB: Je crois que certains contextes ne se prêtent pas bien a l'ouverture de toutes les légendes en un clic:
Exemple chez nous nous avons un contexte avec 71 couches et nos légendes sont souvent complexe
-> plusieurs élément qui prennent beaucoup d'espace (surtout en mobile)
Dans ce cas je ne crois pas que de les ouvrir toutes dans un coup sera gagnant... Serait même à proscrire. De plus, quel sera la performence de ceci sur 71 getLegend....

@ameliebernier ameliebernier added duplicate Duplicate issues // Doublons enhancement New features and improvements // Nouvelles fonctionnalités et améliorations labels Jan 31, 2020
@ameliebernier
Copy link
Contributor Author

Inclus dans infra-geo-ouverte/igo2#397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicate issues // Doublons enhancement New features and improvements // Nouvelles fonctionnalités et améliorations in progress In progress // Développement en cours
Projects
None yet
Development

No branches or pull requests

4 participants