Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context interactive tour #751

Merged
merged 15 commits into from
Nov 16, 2020
Merged

Context interactive tour #751

merged 15 commits into from
Nov 16, 2020

Conversation

PhilippeLafreniere18
Copy link
Contributor

@PhilippeLafreniere18 PhilippeLafreniere18 commented Oct 20, 2020

  • conditions allow to check multiples elements in the current document

  • Adjust class name for the context interactive tour

  • Use the context's config service to check if context's list button should be displayed or not

  • Adjust skipping element method (when element attach to is not defined)

@mbarbeau mbarbeau marked this pull request as draft November 3, 2020 14:51
@PhilippeLafreniere18 PhilippeLafreniere18 marked this pull request as ready for review November 16, 2020 18:41
@mbarbeau mbarbeau merged commit 70d0b8e into next Nov 16, 2020
@mbarbeau mbarbeau deleted the contextInteractiveTour branch November 16, 2020 19:42
mbarbeau pushed a commit that referenced this pull request Nov 16, 2020
* feat(context/interactive-tour): modifs for context interactive tour

* WIP

* lint

* delete unnecessary

* WIP

* WIP

* WIP

* WIP

* feat/fix(interactive-tour): fix skipping element

Co-authored-by: Marc-André Barbeau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants