Zoom feature #361
Merged
Zoom feature #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into zoomFeature
… into zoomFeature
… into zoomFeature
cbourget
reviewed
Dec 2, 2019
| @@ -108,13 +108,16 @@ | |||
| </igo-entity-table> | |||
| </app-expansion-panel> | |||
|
|
|||
| <app-toast-panel | |||
| <app-toast-panel *ngIf="queryStore.entities$.value.length" | |||
There was a problem hiding this comment.
Replace with *ngIf="!(queryStore.empty$ | async)"
cbourget
reviewed
Dec 2, 2019
| return this.results.length ? 'visible' : 'hidden'; | ||
| if (this.results.length) { | ||
| if (this.results.length === 1 && this.initialize) { | ||
| this.selectResult(this.store.entities$.value[0]); |
cbourget
reviewed
Dec 2, 2019
| tooltip: this.languageService.translate.instant('toastPanel.zoomOnFeaturesTooltip'), | ||
| icon: 'magnify-plus', | ||
| availability: () => { | ||
| this.store.all().length > 1 ? this.multiple$.next(true) : this.multiple$.next(false); |
There was a problem hiding this comment.
This is a strange pattern. Availability should react to multiple$, not set it.
cbourget
requested changes
Dec 2, 2019
matrottier
pushed a commit
that referenced
this pull request
Nov 17, 2021
… operator control (#361) * refactor(ogc-filter) Manage ogcfilterwriter usage. * refactor(ogc-filter) interface modified * refactor(wfs-datasource) simplification * feat(wfs-datasource) only call needed fields * refactor(wms-wfs-datasource)Filters to igoFilters * refactor(*) geometry name for filters * refactor(wms-wfs) Moving common utils/methods * refactor(wms-wfs) using shared method and const. * refactor(*) various minor fix * feat(pushButtons)Adding pushbutton over ogcfilters * refactor(*) ogcfilters result from buildFilter * wip(ogc-filters) * feat (wfs,ogcfilters)Enable wfs to have pushbutton * refactor(wfs) build url on empty pushbutton * typo(togglebuttons) * refactor(ogc-filter) switch to mdi SVG icon * feat(ogc-filters) exclude field from sourceFields * refactor(ogc-filter)remove geometry as overlay * refactor(ogc-filter) Minor fixes * feat(ogc-filter) Limit operators's list by type * feat(demo) Add ogcfilters pushButtons example * refactor(*) PR 631 simple reviews part 1 * refactor(ogc) place setter before getter * refactor(ogc) remove mention to showfeatureonmap * refactor(*) PR 631 simple reviews part 2 * refactor(wms & wfs & ogcfilters) defaut values * refactor(wfs) removing mention to wfscapabilities * refactor(wfs) default options for filters. * refactor(wms) way to manage empty sourcefields & pushbuttons * refactor(wfs-service) Simplification * refactor(ogc-filter-toggle-button.component) Simplification by binding a boolean. * refactor(ogc-filter) removing usage of feature extent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibility to allow the user to zoom on selected(s) feature(s) from the toast panel :