Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend unit tests for PSI #117

Closed
Matgrb opened this issue Mar 26, 2021 · 1 comment
Closed

Extend unit tests for PSI #117

Matgrb opened this issue Mar 26, 2021 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@Matgrb
Copy link
Contributor

Matgrb commented Mar 26, 2021

I have recently an issue in PSI test and Bucketers. #116 i suppose that there could be other hidden issues there.

In order to make sure we catch them all, we should design multiple toy examples, covering most of the extreme cases. Then we can write multiple unit tests to make sure that in the future the calculation is correct.

@Matgrb Matgrb added bug Something isn't working enhancement New feature or request labels Mar 26, 2021
@ReinierKoops
Copy link

PSI is removed from the repo since this is better done at other libraries like Feature Engine and Skorecard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants