-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EarlyStoppingShapRFECV to support catboost model #146
Comments
Thanks for making the issue! It would definitely be good to extend support for CatBoost as well. This requires edits in |
@operte This might be interesting for you |
CatBoost has quite a different implementation of early stopping. E.g. it has two options for when to stop: https://catboost.ai/docs/concepts/overfitting-detector.html The approach we took, which is the one taken by LGBM and XGB is equivalent to the So I guess we need to decide how many of CatBoost's options we want to support. |
Let's go for the one we currently support for LGBM and XGB, to be consistent. |
#175 I am proposing a fix for this issue, feedback is welcome, be kind this is my first contribution :) |
I am closing this issue as it seems to be resolved. Feel free to make a new issue if this is not the case. |
Catboost has a little bit different api and currently
EarlyStoppingShapRFECV
throw a error, if I tried to use it:TypeError: fit() got an unexpected keyword argument 'eval_metric'
The text was updated successfully, but these errors were encountered: