Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EarlyStoppingShapRFECV to support catboost model #146

Closed
oleg-savko opened this issue May 4, 2021 · 6 comments
Closed

Add EarlyStoppingShapRFECV to support catboost model #146

oleg-savko opened this issue May 4, 2021 · 6 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@oleg-savko
Copy link

Catboost has a little bit different api and currently EarlyStoppingShapRFECV throw a error, if I tried to use it:

TypeError: fit() got an unexpected keyword argument 'eval_metric'

@oleg-savko oleg-savko added the enhancement New feature or request label May 4, 2021
@Matgrb Matgrb added bug Something isn't working good first issue Good for newcomers labels May 4, 2021
@Matgrb
Copy link
Contributor

Matgrb commented May 4, 2021

Thanks for making the issue! It would definitely be good to extend support for CatBoost as well.

This requires edits in probatus/feature_elimination/feature_elimination.py in lines 965-982, to pass the arguments differently in case the model is instance of CatBoost object. Would anyone like to pick this issue up?

@Matgrb
Copy link
Contributor

Matgrb commented May 4, 2021

@operte This might be interesting for you

@operte
Copy link
Contributor

operte commented May 4, 2021

CatBoost has quite a different implementation of early stopping. E.g. it has two options for when to stop: https://catboost.ai/docs/concepts/overfitting-detector.html

The approach we took, which is the one taken by LGBM and XGB is equivalent to the Iter approach on CatBoost.

So I guess we need to decide how many of CatBoost's options we want to support.

@Matgrb
Copy link
Contributor

Matgrb commented May 4, 2021

Let's go for the one we currently support for LGBM and XGB, to be consistent.

@ClaudioSalvatoreArcidiacono

#175 I am proposing a fix for this issue, feedback is welcome, be kind this is my first contribution :)

@ReinierKoops
Copy link

ReinierKoops commented Mar 20, 2024

I am closing this issue as it seems to be resolved. Feel free to make a new issue if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants