Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this Library Support Regression and/or Multiclass Classification #166

Closed
CMobley7 opened this issue Nov 2, 2021 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@CMobley7
Copy link

CMobley7 commented Nov 2, 2021

To Whom It May Concern,

I found Probatus via the following article, https://medium.com/ing-blog/open-sourcing-shaprfecv-improved-feature-selection-powered-by-shap-994fe7861560, when looking for a way to do RFE with SHAP values on tree-based models. However, I’m attempting to solve both regression and multiclass classification problems. After looking at the documentation, this library appears to only support binary classification. Am I reading the documentation correctly? If so, is this feature on the roadmap?

Thank you for your time and attention to this matter. I hope that this question finds you well and that you have a great rest of the week. God bless.

Very Respectfully,
CMobley7

@CMobley7 CMobley7 added the enhancement New feature or request label Nov 2, 2021
@christophermadsen
Copy link
Contributor

Probatus will work for both regression and classification.

The probatus docs do recommend using LightGBM or XGBoost, so I don't know if all tree-based regression models will work, but conceptually any sklearn-like model should work. You can have a look at the models being tested in the tests.

I have personally run experiments with the LGBMRegressor without any issues on several occassions.

The docs aren't outdated, but there are currently only tests for binary classification.

@CMobley7
Copy link
Author

CMobley7 commented Nov 3, 2021

@christophermadsen ,

Thank you for your quick and thorough response. I really appreciate it. I planned on using either XGBoost or LightGBM; so that works out perfectly.

Thanks again. Have a great rest of the week. God bless.

Very Respectfully,
CMobley7

@CMobley7 CMobley7 closed this as completed Nov 3, 2021
@Matgrb
Copy link
Contributor

Matgrb commented Nov 4, 2021

The idea is we provide full support for binary classifiers for all features. Some features might work with multiclass or regression, especially ShapRFECV, and if they don't please do make an issue. It would be cool to actually add some unit tests for regressors and multiclass to that module, since is is most used one in the package. I made this issue to outline what needs to be done #169

However, some of the features e.g. ShapModelInterpreter will not work with regression as they are right now, due to the fact that the feature measures AUC performance by default. In case there is interest in making other features work, please make an issue, and we see how this can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants