-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERROR in ./node_modules/countup.js-angular2/countUp.module.ts #6
Comments
How are you including the countUp.js-angular2 module? |
Hi, `import { CommonModule } from "@angular/common"; @NgModule({ |
Hi again, |
Gonna need some more info please. What angular version, cli version, and countup.js-angular2 version are you using? I successfully included it in a project using these latest (at time of writing) versions: Angular: 5.2.0 At the very least, make sure you have the most recent countup.js-angular2 version, 1.1.1. |
The problem appears when we try to compile for production (in my case it's in Ionic, but i think it's the same problem of the others). The Angular compiler (version 5.2.9 in my case) is looking for the compiled js files, but in the npm module there are only the typescript files. |
I am able to successfully compile my test project with In the dist folder, everything is compiled down to js. |
Having the same issue now that I upgraded to v6.
Angular 6.0.0 It was building fine in v5.*, but it looks like with the upgrade, that's no longer the case. EDIT:
With that in place, my projects builds fine with |
Any word on this? I am experiencing this as well. As @iplaksiy noted, the error message says the following:
|
For now, use @iplaksiy's solution. I tried rerunning a newer version of ng-packagr, and it results in an AOT error:
Angular still hasn't figured out a good way to pass directives around via npm. Of course, you can always just copy the count-up directive in this repo and declare it in app.module.ts. It's really that simple! But due to all the complicated webpack bundling, transpiling, etc, we have to jump through so many hoops if we want to just npm install it. * sigh * |
Fixed in v6.0.0 |
Module build failed: Error: C:\XXX\node_modules\countup.js-angular2\countUp.directive.ts is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include'
property.
The missing file seems to be part of a third party library. TS files in published libraries are often a sign of a badly packaged library. Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv).
The text was updated successfully, but these errors were encountered: