Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

few songs are only half downloaded #3

Open
L0nelyW0lf opened this issue Dec 15, 2019 · 11 comments
Open

few songs are only half downloaded #3

L0nelyW0lf opened this issue Dec 15, 2019 · 11 comments
Labels
bug Something isn't working

Comments

@L0nelyW0lf
Copy link

Hi bro few songs are only half downloaded tried again & again.
eg: https://www.jiosaavn.com/album/indrum-iniyavai---p-b-sreenivos-love-due/e9gDlzrpj60_
14th song and few other songs too

@inovachrono
Copy link
Owner

Hi bro few songs are only half downloaded tried again & again.

The program relies on a 3rd party downloader package, pySmartDL for faster downloading. Since you are not getting any errors while the program is running that means the download package is not able to download the entire song. I have tried fixing this earlier but couldn't.

The only way of fixing this would be to use some other download package that is more robust and can deliver good download speeds. I'll look into this one.

@inovachrono
Copy link
Owner

inovachrono commented Dec 15, 2019

I'm testing a new downloader package, wget. With this I was able to completely download the song but I did notice performance drop in download speeds. I hope you can clarify this for me.

Download the one below and run the pip install requirements.txt again.
issue01

@L0nelyW0lf
Copy link
Author

bro i tried and getting this

...
Initiating Album Downloading
Album name: Indrum Iniyavai - P B Sreenivos Love Due
Downloading Yaar Yaar Yaar Aval.m4a
...
Please paste link of album or playlist

DONE
not moving after this

@inovachrono
Copy link
Owner

The thing is you need to delete the half downloaded songs from folder for them to be downloaded again.

@L0nelyW0lf
Copy link
Author

Actually i extracted the contents in new folder and then only i tried. But I tried to pip install requirements nothing new downloaded everything was already there.

@L0nelyW0lf
Copy link
Author

Did a work around and installed wget manually and replaced new files with old files. but it works only when it has unfinished and deleted files. If we start a new album to dwonload it downloads one file temporarily and says done.

Enter the url: https://www.jiosaavn.com/album/endrum-iniyavai---p.-susheela/HGpSnMrqkiM_
...
Initiating Album Downloading
Album name: Endrum Iniyavai - P. Susheela
Downloading Vaa Arugil Vaa.m4a
100% [########################################################################] 11M / 11M...
Please paste link of album or playlist

DONE

@inovachrono
Copy link
Owner

I tested wget and I find it much worse than pySmartDL. It is unable to download albums at times. I think I'll move back to pySmartDL for now though we will still be having half downloaded songs issue at times. I may be have to code the download part myself but it won't be as efficient as pySmartDL.

I thank you for your valuable feedback and support.

@L0nelyW0lf
Copy link
Author

i thank you for responding me. expecting a fix for half songs. thanks once again bro.

@inovachrono
Copy link
Owner

i thank you for responding me. expecting a fix for half songs. thanks once again bro.

Will work on it. And should probably be able to fix and upload it in a couple of days.

@L0nelyW0lf
Copy link
Author

Is this fixed bro.

@inovachrono
Copy link
Owner

inovachrono commented Dec 19, 2019

Is this fixed bro.

I did write the code but its slow and not as optimized as pySmartDL. The code can be found at this link.

However it is highly recommended that you use the code available in master branch for regular, faster and reliable downloads

@inovachrono inovachrono added the bug Something isn't working label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants