Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storybook): allow to choose different versions in storybook #1022

Merged
merged 14 commits into from
Sep 1, 2023
Merged

feat(storybook): allow to choose different versions in storybook #1022

merged 14 commits into from
Sep 1, 2023

Conversation

TobiasHeimGalindo
Copy link
Collaborator

@TobiasHeimGalindo TobiasHeimGalindo commented Jul 14, 2023 •
edited
Loading

Closes #963 & #1026

Preview:

Video.mp4

@TobiasHeimGalindo TobiasHeimGalindo changed the title feat: allow to choose different storybook versions feat(storybook): allow to choose different versions in storybook Jul 14, 2023
@TobiasHeimGalindo TobiasHeimGalindo force-pushed the elements-#963-allow-different-storybook-versions branch from ae6709e to 05846b4 Compare July 14, 2023 11:33
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as ready for review July 20, 2023 15:03
MariaLStefan
MariaLStefan reviewed Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@MariaLStefan MariaLStefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me that has the problem, or can any of you load the hosted-version.json? I get a 404...

@TobiasHeimGalindo TobiasHeimGalindo mentioned this pull request Aug 11, 2023
Merged
@TobiasHeimGalindo
Copy link
Collaborator Author

TobiasHeimGalindo commented Aug 11, 2023 •
edited
Loading

Is it just me that has the problem, or can any of you load the hosted-version.json? I get a 404...

@MariaLStefan

It should work again, hosted-version.json is now excluded for cleanup in our master branch

@TobiasHeimGalindo TobiasHeimGalindo temporarily deployed to github-pages August 17, 2023 09:00 — with GitHub Actions Inactive
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as draft August 17, 2023 09:22
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as ready for review August 17, 2023 10:47
@TobiasHeimGalindo TobiasHeimGalindo linked an issue Aug 17, 2023 that may be closed by this pull request
Design and Layout with Version Selection on Landingpage Library page #1026
Closed
@MariaLStefan
refactor(landingpage): improve look of version picker
e1a6012
@MariaLStefan
refactor(landinpage): nav-style change
13dff9a 
- remove alignment center for nav items because of decrease readability
MariaLStefan
MariaLStefan previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@MariaLStefan MariaLStefan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I just adjusted the styling a little bit to fit the overall design. Ready to merge!
image

@silentHoo
Copy link
Member

Two last changes:

  • Limit the height of the dropdown list
  • Reorder the version list in descending order (starting with the newest version at top, oldest version at bottom)

@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as draft August 30, 2023 08:30
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as ready for review August 31, 2023 09:47
@janivo janivo merged commit 9028657 into master Sep 1, 2023
@janivo janivo deleted the elements-#963-allow-different-storybook-versions branch September 1, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janivo janivo janivo approved these changes

@MariaLStefan MariaLStefan Awaiting requested review from MariaLStefan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@TobiasHeimGalindo @silentHoo @janivo @MariaLStefan