Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elements|ino-nav-drawer): accesibility improvements #1036

Merged
merged 7 commits into from
Aug 11, 2023
Merged

feat(elements|ino-nav-drawer): accesibility improvements #1036

merged 7 commits into from
Aug 11, 2023

Conversation

Sl1nd
Copy link
Contributor

@Sl1nd Sl1nd commented Aug 3, 2023 •
edited
Loading

Closes #979

Proposed Changes

  • Add aria-labels to nav elements
  • Refactor use proper semantics
  • Adjust nav-drawer story to show correct usage

@Sl1nd Sl1nd temporarily deployed to github-pages August 3, 2023 16:09 — with GitHub Actions Inactive
@TobiasHeimGalindo
Copy link
Collaborator

@Sl1nd Looks good! fixed a typo and updated the story to expose the a11yLabels args, so now users can directly see and modify labels. If everything seems in order, feel free to merge.

@Sl1nd Sl1nd merged commit 347edb4 into master Aug 11, 2023
@Sl1nd Sl1nd deleted the elements-979-a11y-nav-drawer branch August 11, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasHeimGalindo TobiasHeimGalindo TobiasHeimGalindo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessible ino-nav-drawer
2 participants
@Sl1nd @TobiasHeimGalindo