refactor(elements|ino-switch): remove color-scheme prop #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: update ino-switch design * refactor: update states * refactor: finalize styling * chore: elements stencil docs * chore: unix line ending to reduce noise
MariaLStefan
requested changes
Aug 30, 2022
janivo
added
the
breaking change
janivo
requested changes
Sep 2, 2022
|
One thing I noticed: The height of the disabled and non-disabled We should set a fixed height (the height of the disabled one), to prevent these jumps. Could you do that in this PR as well? |
janivo
previously approved these changes
Sep 23, 2022
janivo
added
the
ready for next major
janivo
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #707
Proposed Changes
-removes the color-scheme property of the ino-switch component