Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(elements|ino-chip): update design #752

Merged
merged 3 commits into from
Oct 17, 2022
Merged

style(elements|ino-chip): update design #752

merged 3 commits into from
Oct 17, 2022

Conversation

MariaLStefan
Copy link
Collaborator

Closes #728

@MariaLStefan MariaLStefan temporarily deployed to github-pages September 28, 2022 13:17 Inactive
BenPag
BenPag requested changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@BenPag BenPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank´s for your work! Currently I only checked your code :)

packages/elements/src/components/ino-carousel/ino-carousel.e2e.ts Outdated Show resolved Hide resolved
packages/elements/src/components/ino-chip/ino-chip.scss Outdated Show resolved Hide resolved
packages/elements/src/components/ino-chip/ino-chip.scss Outdated Show resolved Hide resolved
packages/elements/src/components/ino-chip/ino-chip.scss Outdated Show resolved Hide resolved
@MariaLStefan
refactor(elements|ino-chip): add requested changes
981edb0 
- convert hex 8 to rgba
- remove comment in `ino-carousel.e2e.ts`
- remove comment `use new-theme`
- change rgba(255, 255, 255, 0) to `transparent`
@janivo
Copy link
Collaborator

janivo commented Oct 5, 2022

image

This section can be removed

janivo
janivo requested changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@janivo janivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, nice job 👍🏼

packages/elements/src/components/ino-chip/ino-chip.scss Outdated Show resolved Hide resolved
@BenPag BenPag added the breaking change This issue introduces changes need to be made by the consumer label Oct 12, 2022
@janivo janivo changed the title refactor(elements|ino-chip): apply new design style(elements|ino-chip): update design Oct 17, 2022
@janivo janivo enabled auto-merge (squash) October 17, 2022 16:26
@janivo janivo disabled auto-merge October 17, 2022 16:26
@janivo janivo merged commit 26dbacd into master Oct 17, 2022
@janivo janivo deleted the elements-#728-apply-new-ino-chip-design branch October 17, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPag BenPag BenPag requested changes

@janivo janivo janivo approved these changes

Assignees
No one assigned
Labels
breaking change This issue introduces changes need to be made by the consumer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the new design of ino-chip
3 participants
@MariaLStefan @janivo @BenPag