Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

delete clusterrole on clean or split the cleanup steps in two commands #51

Open
hacker-h opened this issue Aug 22, 2019 · 1 comment
Open

delete clusterrole on clean or split the cleanup steps in two commands #51

hacker-h opened this issue Aug 22, 2019 · 1 comment
Labels
cleanup enhancement New feature or request good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/

Comments

@hacker-h
Copy link
Contributor

Currently the illuminatio clean command currently deletes the clusterrole binding but not the clusterrole. Users should be able to easily purge all resources created by illuminatio.
I think this should be done together either on clean or in new command e.g. purge to delete all non-namespaced resources created by illuminatio while clean deletes the namespaced resources.

What do you think @johscheuer ?
@hacker-h hacker-h added enhancement New feature or request cleanup labels Aug 22, 2019
@johscheuer
Copy link
Contributor

IMHO I would integrate it in the clean command.

@hacker-h hacker-h added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 22, 2019
@johscheuer johscheuer removed the help wanted Extra attention is needed label Aug 23, 2019
@hacker-h hacker-h added the hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cleanup enhancement New feature or request good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johscheuer @hacker-h