Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Release notes are overwritten #47

Closed
1 task done
judy-inpsyde opened this issue Jun 9, 2023 · 2 comments · Fixed by #48
Closed
1 task done

[Bug]: Release notes are overwritten #47

judy-inpsyde opened this issue Jun 9, 2023 · 2 comments · Fixed by #48
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@judy-inpsyde
Copy link

judy-inpsyde commented Jun 9, 2023

Description of the bug

The packages that are using Build, release notes are overwritten with Compiled assets available in.... lately.

This is potentially due to https://github.com/svenstaro/upload-release-action/blob/master/src/main.ts#L77-L83

They have introduced the overwrite option but we have it fixed here https://github.com/inpsyde/reusable-workflows/blob/main/.github/workflows/build-assets-compilation.yml#L143

Example repos:

Reproduction instructions

  1. Utilize https://github.com/inpsyde/reusable-workflows/blob/main/.github/workflows/build-assets-compilation.yml with your package.
  2. Create a release with notes.
  3. Check the release note once the asset is built.

Expected behavior

Release notes to not be overwritten. Perhaps, a new config/input that we can say true or false for the overwrite value.

Environment info

No response

Relevant log output

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@judy-inpsyde judy-inpsyde added the bug Something isn't working label Jun 9, 2023
@tyrann0us tyrann0us added the good first issue Good for newcomers label Jun 9, 2023
@tyrann0us
Copy link
Member

Perhaps, a new config/input that we can say true or false for the overwrite value.

I’d vote to remove the argument (it defaults to false) because I don’t see any reason why we’d want to overwrite custom release notes.

@Chrico
Copy link
Member

Chrico commented Jun 12, 2023

Thanks for your work @judy-inpsyde 💪🏻 Jep, I agree that it makes no sense to overwrite the current release.

Might be related to changes from https://github.com/svenstaro/upload-release-action/pull/106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants