Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DRep extended keys #320

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Support DRep extended keys #320

merged 2 commits into from
Oct 18, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 17, 2023

Changelog

- description: |
    Add support for DRep extended keys
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Main PR to fix IntersectMBO/cardano-cli#358

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@smelc smelc requested a review from a team as a code owner October 17, 2023 14:42
@smelc smelc added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit c41e5eb Oct 18, 2023
@smelc smelc deleted the smelc/drep-extended-key branch October 18, 2023 08:39
newhoggy added a commit that referenced this pull request Mar 11, 2024
…to-cardano-api-8.24

Update to `cardano-api-8.23.1.0`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert a dRep extended vkey to a non-extended one:
2 participants