Replace IsCardanoEra
and IsShelleyBasedEra
contraints in GADT constructors with Typeable
#354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
There are very few places where we need
IsCardanoEra
andIsShelleyBasedEra
in these GADTs.In these few remaining places,
cardanoEraConstraints
andshelleyBaseConstraints
can be used to get the constraints instead.Removing these constraints is helpful because whilst it makes it more convenient when unpacking the GADT, when constructing the GADT it is more inconvenient because the declared constraints need to be available on construction.
Moreover, the removal of these constraints makes the modified GADTs more compatible with
EraInEon
.Downstream
cardano-cli
changes: IntersectMBO/cardano-cli#435How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist