Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CardanoNodeClient is being provided with the genesis protocol version, rather than the node config value #454

Closed
6 tasks done
rhyslbw opened this issue Mar 18, 2021 · 0 comments
Closed
6 tasks done

CardanoNodeClient is being provided with the genesis protocol version, rather than the node config value #454

rhyslbw opened this issue Mar 18, 2021 · 0 comments
Assignees
@rhyslbw
Labels
BUG SEVERITY:LOW Small defects which does not prevent any crucial functionality to work.

Comments

@rhyslbw
Copy link
Contributor

rhyslbw commented Mar 18, 2021 •
edited
Loading

Environment

{
  os: {
    arch: 'x64',
    cpus: { count: 16, model: 'AMD Ryzen 7 3700X 8-Core Processor' },
    release: '5.8.0-45-generic',
    totalMem: 33597571072,
    type: 'Linux'
  },
  version: '3.2.0'
}

Platform

  • Linux / Ubuntu
  • Linux / Other
  • macOS
  • Windows

Platform version:

Runtime

  • Node.js
  • Docker

Steps to reproduce the bug

na

What is the expected behavior?

https://github.com/input-output-hk/cardano-graphql/blob/804d02bd0df6ffc477c7d274d4004a69b9ceb0bb/packages/api-cardano-db-hasura/src/CardanoNodeClient.ts#L33

expects to be provided from:
https://github.com/input-output-hk/cardano-graphql/blob/804d02bd0df6ffc477c7d274d4004a69b9ceb0bb/config/network/mainnet/cardano-node/config.json#L7

but is instead being provided from:
https://github.com/input-output-hk/cardano-graphql/blob/804d02bd0df6ffc477c7d274d4004a69b9ceb0bb/config/network/mainnet/genesis/shelley.json#L6
@rhyslbw rhyslbw added BUG SEVERITY:LOW Small defects which does not prevent any crucial functionality to work. labels Mar 18, 2021
@rhyslbw rhyslbw self-assigned this Mar 18, 2021
rhyslbw added a commit that referenced this issue Mar 18, 2021
@rhyslbw
fix: use cardano-node config for lastConfiguredMajorVersion
76aba4e 
Last configured version was intended to be sourced from the
cardano-node config, yet it's currently coming from genesis.

Fixes #454

(cherry picked from commit 5a621c2)
rhyslbw added a commit that referenced this issue Apr 6, 2021
@rhyslbw
fix: use cardano-node config for lastConfiguredMajorVersion
d9c2a2d 
Last configured version was intended to be sourced from the
cardano-node config, yet it's currently coming from genesis.

Fixes #454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhyslbw rhyslbw

Labels
BUG SEVERITY:LOW Small defects which does not prevent any crucial functionality to work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhyslbw