Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode pool metadata hash as hex in PoolMetaData ToJSON #1596

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

intricate
Copy link
Contributor

Before:

{
  "hash": "j\u001a½\u0002.hg+Ìuñæ'ë\u001akÅN5\tcÃuØ8F\u001aÁ̯h",
  "url": "..."
}

After:

{
  "hash": "6a1abd022e68672bcc75f18ae627eb1a6bc54e350963c375d838461ac1ccaf68",
  "url": "..."
}

@intricate intricate requested a review from uroboros as a code owner June 29, 2020 16:21
@intricate intricate self-assigned this Jun 29, 2020
@intricate
Copy link
Contributor Author

Oops, I need to fix the golden tests.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@intricate intricate force-pushed the intricate/base16-tojson-pool-mdhash branch from b93f8bd to f777342 Compare June 30, 2020 14:18
@intricate intricate merged commit 5e69859 into master Jun 30, 2020
@iohk-bors iohk-bors bot deleted the intricate/base16-tojson-pool-mdhash branch June 30, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants