Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertions: part 2 #1629

Merged
merged 6 commits into from
Jul 8, 2020
Merged

Assertions: part 2 #1629

merged 6 commits into from
Jul 8, 2020

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Jul 8, 2020

Turns out that the assertions weren't firing owing to fun with laziness.

Tests have all been modified to enable assertions.

Assertions added to various places in the code.

@nc6 nc6 requested review from JaredCorduan and redxaxder July 8, 2020 11:33
@nc6 nc6 requested a review from uroboros as a code owner July 8, 2020 11:33
Copy link
Contributor

@uroboros uroboros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 I'm keen to start testing with this

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nc6 nc6 merged commit 47e2075 into master Jul 8, 2020
@iohk-bors iohk-bors bot deleted the nc/assertions branch July 8, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants