spec typos: POOLREAP to update fPoolParams, and change variable name kh to hk #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formal spec did not remove the retiring pools from the fPoolParams mapping in the POOLREAP rule. (it was, however, correct in the implementation). Additionally, in the spec and in the implementation, there was a variable kh that should have been hk to be consistent with the rest of the spec.
uroboros
approved these changes
Jul 14, 2020
| @@ -521,6 +522,7 @@ \subsection{Pool Reaping Transition} | |||
| ~ \\ | |||
| \varUpdate{\var{retired}} & \varUpdate{\subtractdom} & \varUpdate{\var{stpools}} \\ | |||
| \varUpdate{\var{retired}} & \varUpdate{\subtractdom} & \varUpdate{\var{poolParams}} \\ | |||
| \varUpdate{\var{retired}} & \varUpdate{\subtractdom} & \varUpdate{\var{fPoolParams}} \\ | |||
There was a problem hiding this comment.
It's worth noting that removing retirees from fPParams in POOLREAP is benign because fPParams is emptied out in EPOCH just before calling POOLREAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formal spec did not remove the retiring pools from the
fPoolParamsmapping in thePOOLREAPrule. It was, however, correct in the implementation.In the spec and in the implementation, there was a variable
khinPOOLREAPthat should have been namedhkto be consistent with the rest of the spec.In the
POOLtransition, the formal spec had backward inequality (but the implementation was correct). The pool cost should be at least as big an the minimum cost.closes #1654
closes #1656