Simplify the VRF mkSeed #1659
Merged
Simplify the VRF mkSeed #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
approved these changes
Jul 14, 2020
|
Well perhaps I'm missunderatanding 2. I've backed it out for now. |
nc6
approved these changes
Jul 14, 2020
This makes two actual: 1. change the hash function from SHA256 3. serialise the slot number using raw serialisation, not CBOR On 1, SHA256 was just the default suggestion, not a requirement. It's simpler to simply use the same 256bit hash as we use everywhere else. On 2, we should avoid CBOR serialisation for internal hashing, signing etc. For one thing it's not quick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two actual:
On 1, SHA256 was just the default suggestion, not a requirement. It's
simpler to simply use the same 256bit hash as we use everywhere else.
On 2, we should avoid CBOR serialisation for internal hashing, signing
etc. For one thing it's not quick.