Add signable representations #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use this in place of the tuple previously. We now have full control of how this is serialised for signing.
To construct the SignableRepresentation for OCertSignable, rather than manually appending bytestrings created in different ways.
dcoutts
requested changes
Jul 15, 2020
Comment on lines
149
to
150
| <> BSL.toStrict (Binary.encode counter) | ||
| <> writeBinaryWord64 (fromIntegral $ unKESPeriod period) |
There was a problem hiding this comment.
These two should both be at-most 64bit numbers, so we should serialise them the same.
tbh, we should probably use Word64 for the cert counter not natural.
|
@dcoutts I agree that the counter should probably be bounded, but on the basis that it's not, I'm wary of serialising it as if it is, since that allows a potential attack. Since we compare the counter, one could replay the ocert counter |
dcoutts
approved these changes
Jul 15, 2020
Comment on lines
146
to
149
| BSL.toStrict . Binary.runPut $ do | ||
| Binary.putByteString (KES.rawSerialiseVerKeyKES vk) | ||
| Binary.put counter | ||
| Binary.putWord64be (fromIntegral $ unKESPeriod period) |
There was a problem hiding this comment.
The bytestring builder will be faster
Suggested change
| BSL.toStrict . Binary.runPut $ do | |
| Binary.putByteString (KES.rawSerialiseVerKeyKES vk) | |
| Binary.put counter | |
| Binary.putWord64be (fromIntegral $ unKESPeriod period) | |
| runByteBuilder (32+8+8) $ do | |
| BS.byteStringCopy (KES.rawSerialiseVerKeyKES vk) | |
| BS.word64BE counter | |
| BS.word64BE (fromIntegral $ unKESPeriod period) |
Needs
import Shelley.Spec.Ledger.Serialization (runByteBuilder)
import qualified Data.ByteString.Builder as BS
import qualified Data.ByteString.Builder.Extra as BS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.