Make compact values more compact #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoutts
reviewed
Jan 6, 2021
redxaxder
force-pushed
the
redxaxder/compact2
branch
4 times, most recently
from
f96ac50 to
4360965
Compare
kevinhammond
previously requested changes
Jan 14, 2021
There was a problem hiding this comment.
My understanding is that the main change here is
- to the representation of CompactValue to give a short form for Ada-only tokens
- to map token quantities etc to different memory regions (to give a more efficient storage and access pattern)
The implications in terms of memory usage are quite subtle (and maybe architecture dependent?). I would suggest making this explicit in a comment at the start of the file, so that it could be changed in future if required (otherwise, this could take some time to unpick and redo!). I would also include some pointers to any relevant benchmarking.
It presumably also affects the minutxo calculation, so there should be a reference to this from within the file?
nc6
reviewed
Jan 15, 2021
nc6
approved these changes
Jan 15, 2021
| -- These represent the index, pid offset, asset name offset, and quantity. | ||
| -- If any of the quantities out of bounds, this will produce Nothing. | ||
| -- The triples are ordered so that a component with an asset name appearing | ||
| -- earlier in the asset name section is first. |
There was a problem hiding this comment.
Is this ordering stable? What happens with multiple null asset names, which will share the offset? Can this result in different representations, and do we care?
redxaxder
force-pushed
the
redxaxder/compact2
branch
from
a62a2e9 to
692a0a4
Compare
nc6
approved these changes
Jan 18, 2021
nc6
reviewed
Jan 18, 2021
redxaxder
force-pushed
the
redxaxder/compact2
branch
from
03a0bd2 to
0e08843
Compare
redxaxder
force-pushed
the
redxaxder/compact2
branch
from
0e08843 to
d8f404a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.