Miscellaneous fixes #2539
Merged
Miscellaneous fixes #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to compute the hash for dependencies when bumping in cabal.project. In particular using this git alias (from @redxaxder): ``` [alias] nix = !nix-prefetch-git \"file://$(git rev-parse --show-toplevel)\" --rev \"$(git rev-parse HEAD)\" 2>&1 | grep 'sha256\\|rev\"' | sed 's/\"rev\"/tag/g' | sed 's/\"sha256\"/--sha256/g' | sed 's/[,\"]//g' ```
lehins
approved these changes
Nov 5, 2021
|
I think you also need to update ormolu in github actions https://github.com/input-output-hk/cardano-ledger/blob/4347e54b2827090e898702ccfb93cc731b4a1909/.github/workflows/haskell.yml#L145 |
The ormolu version in use was quite old. This commit bumps it to later and reformats. I have eyeballed the changes and think they're generally improvements. They mostly fit into three groups: - The expression `(x -n)` is now formatted as `(x - n)`. - A space is enforced after the -- in a comment.
|
Turns out we don't use the nix specified version in CI, so I've downbumped it to the 3.1.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit can be reviewed independently.