Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarking #2561

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Benchmarking #2561

merged 3 commits into from
Nov 25, 2021

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Nov 24, 2021

  • Update the Tx benchmarks (formats had changed and they were no longer running)
  • Update the description of how to generate the files
  • Add a benchmarking workflow

@github-pages github-pages bot temporarily deployed to github-pages November 24, 2021 12:23 Inactive
@nc6 nc6 marked this pull request as ready for review November 24, 2021 12:37
@nc6 nc6 requested a review from lehins November 24, 2021 13:42
lehins
lehins approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is pretty cool. TIL about benchmarks with github actions.

FYI. See #2563 for the fix for CI failure. It is benign so feel free to rerun the CI make it pass

nc6 added 3 commits November 24, 2021 22:01
@nc6
Update benchmark transactions.
3b42620 
There was a slight change in the transaction format, and the previous
transactions were not working. Update them, and update the description
of how to generate them.
@nc6
Remove tpraos symlink
0ff55dc
@nc6
Add benchmark workflow.
1e30d44
@nc6 nc6 merged commit 1df452b into master Nov 25, 2021
@iohk-bors iohk-bors bot deleted the nc/bench-tx branch November 25, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nc6 @lehins