Replace roundtripCBOR with trippingCbor #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
changed the title
newhoggy
force-pushed
the
newhoggy/replace-roundtrip_CBOR-with-trippingCBOR
branch
from
2357ebb to
0ef2e8c
Compare
newhoggy
requested review from
deepfire,
jutaro,
mgmeier,
fmaste,
cleverca22,
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
newhoggy/replace-roundtrip_CBOR-with-trippingCBOR
branch
from
0ef2e8c to
e8b50c5
Compare
newhoggy
changed the title
carbolymer
approved these changes
Apr 7, 2023
newhoggy
force-pushed
the
newhoggy/replace-roundtrip_CBOR-with-trippingCBOR
branch
3 times, most recently
from
6830f1d to
9384c16
Compare
mgmeier
reviewed
Apr 14, 2023
| -> (TxInsCollateral era, [Fund]) | ||
| -> TxFee era | ||
| -> TxMetadataInEra era | ||
| -> TxGenerator era | ||
| genTx protocolParameters (collateral, collFunds) fee metadata inFunds outputs | ||
| genTx _era protocolParameters (collateral, collFunds) fee metadata inFunds outputs |
There was a problem hiding this comment.
Can I ask what the motivation for the change is? I don't find any in the scope of this PR (as in: it builds and behaves fine without that change)?
If it is some kind of future-proofing, why not use cardanoEra @era in the body of genTx without changing call sites?
There was a problem hiding this comment.
Please see this comment:
By passing in the era as an argument, the caller can easily specify which era they want to run a property test for.
There was a problem hiding this comment.
Yes of course, that makes total sense then.
Thank you @newhoggy
newhoggy
commented
Apr 14, 2023
mgmeier
approved these changes
Apr 14, 2023
… use more of in tests in the future and the function doesn't reduce the code by that much.
…es not yet behave era dependently
newhoggy
force-pushed
the
newhoggy/replace-roundtrip_CBOR-with-trippingCBOR
branch
from
9384c16 to
2be0d46
Compare
iohk-bors
bot
deleted the
newhoggy/replace-roundtrip_CBOR-with-trippingCBOR
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roundtripCBORwas used to reduce the amount of code for round trip tests, but it does not work well with GADTs.We expect to use GADTs more in these tests in order to make them era independent.
Work-arounds for
roundtripCBORhave been used to make it possible to encode tests for multiple eras. These include:[TestTree]instead of aPropertyThis PR introduces
trippingCborwhich captures the tripping part of the property test.It turns out that writing out the property test directly rather than generating the property gives us the flexibility to use GADTs and thus be able to encode era independent property tests, which allows us to eliminate per era duplication and avoid generating test groups.