-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace remaining FilePath
use in cardano-api
#5217
Replace remaining FilePath
use in cardano-api
#5217
Conversation
FilePath
use in cardano api
FilePath
use in cardano apiFilePath
use in cardano-api
@@ -77,6 +77,15 @@ module Cardano.Api.LedgerState | |||
-- ** Environment | |||
, Env(..) | |||
, genesisConfigToEnv | |||
|
|||
, ByronGenesisConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move these types to Cardano.Api.Genesis
and export them via Cardano.Api
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Some additional types that were defined in this module also had to move with them.
222c965
to
d9da059
Compare
d9da059
to
73e0b46
Compare
73e0b46
to
9eda83b
Compare
…enesisFile to Cardano.Api.Genesis
9eda83b
to
6f726c6
Compare
Description
After this change,
cardano-api
is usingFile
types exclusively.Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.