Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remaining FilePath use in cardano-api #5217

Merged

Conversation

newhoggy
Copy link
Contributor

Description

After this change, cardano-api is using File types exclusively.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review May 10, 2023 13:14
@newhoggy newhoggy changed the title Replace remaining file path use in cardano api Replace remaining FilePath use in cardano api May 10, 2023
@newhoggy newhoggy changed the title Replace remaining FilePath use in cardano api Replace remaining FilePath use in cardano-api May 10, 2023
@@ -77,6 +77,15 @@ module Cardano.Api.LedgerState
-- ** Environment
, Env(..)
, genesisConfigToEnv

, ByronGenesisConfig
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move these types to Cardano.Api.Genesis and export them via Cardano.Api instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Some additional types that were defined in this module also had to move with them.

@newhoggy newhoggy force-pushed the newhoggy/replace-remaining-FilePath-use-in-cardano-api branch from 222c965 to d9da059 Compare May 10, 2023 22:02
@newhoggy newhoggy requested a review from Jimbo4350 May 10, 2023 22:03
@newhoggy newhoggy force-pushed the newhoggy/replace-remaining-FilePath-use-in-cardano-api branch from d9da059 to 73e0b46 Compare May 10, 2023 22:04
@newhoggy newhoggy force-pushed the newhoggy/replace-remaining-FilePath-use-in-cardano-api branch from 73e0b46 to 9eda83b Compare May 10, 2023 23:51
@newhoggy newhoggy force-pushed the newhoggy/replace-remaining-FilePath-use-in-cardano-api branch from 9eda83b to 6f726c6 Compare May 11, 2023 00:08
@newhoggy newhoggy added this pull request to the merge queue May 11, 2023
Merged via the queue into master with commit b7cbe28 May 11, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/replace-remaining-FilePath-use-in-cardano-api branch May 11, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants