Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each client ShouldPostFanout when observing the OnCloseTx #279

Closed
ch1bo opened this issue Mar 22, 2022 · 0 comments
Closed

Each client ShouldPostFanout when observing the OnCloseTx #279

ch1bo opened this issue Mar 22, 2022 · 0 comments
Labels
bug 🐛 Something isn't working
Milestone
0.4.0

Comments

@ch1bo
Copy link
Member

ch1bo commented Mar 22, 2022

We usually have Heads with very short contestation periods (10sec) and on testnet that is too quick after seeing the Close client input.

Instead all hydra nodes should try to fanout by scheduling a ShouldPostFanout when seeing the OnChainTx event.
@ch1bo ch1bo added the bug 🐛 Something isn't working label Mar 22, 2022
@ch1bo ch1bo added this to the 0.4.0 milestone Mar 22, 2022
ghost pushed a commit that referenced this issue Mar 22, 2022
@abailly
Remove contestationDeadline from OnCloseTx #279
a90d698 
This is not enforced so YAGNI
ghost pushed a commit that referenced this issue Mar 22, 2022
@abailly
Remove contestationDeadline from OnCloseTx #279
6822ac7 
This is not enforced so YAGNI
ghost pushed a commit that referenced this issue Mar 22, 2022
@abailly
Fix JSON schemas to remove contestationDeadline #279
1859c98 
Currently duplicated specs ?
ghost pushed a commit that referenced this issue Mar 22, 2022
@abailly
All parties should attempt to post fanout tx #279
c855693 
This only adapt the behaviour test to express the expected logic change.
ghost pushed a commit that referenced this issue Mar 22, 2022
@abailly
Remove faulty.json files incorrectly committed #279
dcdbdfa
ghost pushed a commit that referenced this issue Mar 22, 2022
@abailly
Ignore faulty golden tests files #279
d1c53d4
ghost pushed a commit that referenced this issue Mar 22, 2022
@abailly
Do not crash on failed on-chain tx submission #279
d66120e 
Instead, report the error in logs. This reported errors are lame
because of the lack of proper JSON support in dependent libraries so
we should improve this situation by providing our own or report
upstream.

We should also report the failure to the end-user possibly by throwing
a `PostTxError`.
ghost pushed a commit that referenced this issue Mar 22, 2022
@abailly
Throw PostTxError when tx submission fails #279
5a26e94 
This code does some arguably ugly things to ensure the failures in the
tx submission thread are thrown into the postTx callback's thread in
order to be caught at the Node level and not crash. The TQueue for
submission should probably be simplified to a TMVar or something as
evertyhing is synchronous now.
@KtorZ KtorZ closed this as completed in 0b7b7a6 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
1 participant
@ch1bo