Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky ModelSpec #535

Closed
ch1bo opened this issue Oct 5, 2022 · 5 comments
Closed

Flaky ModelSpec #535

ch1bo opened this issue Oct 5, 2022 · 5 comments
Assignees
Labels
bug 🐛 Something isn't working

Comments

@ch1bo
Copy link
Member

ch1bo commented Oct 5, 2022

The ModelSpec is failing on some trace executions, leading to a flaky CI:

https://github.com/input-output-hk/hydra-poc/actions/runs/3188268110/jobs/5200728011

Last observed on commit: 2d8a6f0

   To rerun use: --match "/Hydra.Model/implementation respects model/"

Randomized with seed 1812008094
@ghost
Copy link

ghost commented Oct 11, 2022

Another instance: https://github.com/input-output-hk/hydra-poc/actions/runs/3224136770/jobs/5274943489#step:8:626

  To rerun use: --match "/Hydra.Model/check conflict-free liveness/"

Randomized with seed 1098815834

@ghost ghost self-assigned this Oct 11, 2022
@ghost
Copy link

ghost commented Oct 12, 2022

Looks like we have a clear picture of why these errors happen:

  • We try to post a NewTx with a value of 0 and there's not corresponding UTxO because the 0 value gets "folded" into an empty asset map.
  • This happens because we initially commit a UTxO with a value of 0
  • This happens because we can generate 0 ADA values commits which does not make sense

@pgrange
Copy link
Contributor

pgrange commented Oct 12, 2022

I've just created this branch with a Model test that proves that we are currently generating UTxO with 0 Ada (and so fails):
https://github.com/input-output-hk/hydra-poc/tree/flaky_model_spec

cabal test hydra-node --test-options='--match Model'

@pgrange pgrange mentioned this issue Oct 13, 2022
2 tasks
@ghost
Copy link

ghost commented Oct 14, 2022

Closed by #552 (hopefully)

@ch1bo
Copy link
Member Author

ch1bo commented Oct 14, 2022

So.. let's close this then until it re-appears.

@ch1bo ch1bo closed this as completed Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants