Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensemble/192/fanout deadline #359

Merged
24 commits merged into from
May 24, 2022
Merged

Ensemble/192/fanout deadline #359

24 commits merged into from
May 24, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2022 •
edited by ghost
Loading

fix #357

abailly and others added 12 commits May 19, 2022 11:02
@abailly @ch1bo
Set Fanout tx lower bound and check it's above contestation deadline
ab7815a
@abailly @ch1bo
Do not adjust fanout lower bound
25fad00 
We added a grace period of 100 slots meaning the transaction is very
likely to be rejected when we post it, esp. in a test setting. As ETE
test is also failing because we don't wait enough, this should make it
possible to have the ETE tests pass but we should have a better story
for resubmitting transactions.
@ch1bo
Use protocol version 6 in hydra-cluster
551fad2 
This fixes slot to posix time conversion!
@ch1bo
Rename TimeHandle functions to be consistent
3bd4d47
@abailly @ch1bo
Add grace period before posting fanout tx
c0c546f
@ch1bo
Increase grace periods and timeouts to make it pass
3bfadfe
@ch1bo
Change our expectation on the e2e test
a083f83
@ch1bo
Add a remainingContestationPeriod to OnCloseTx
f91d090
@abailly
Fake computing remaining period upstream
eca0b47
@ch1bo
Calculate remainingContestationPeriod in Hydra.Chain.Direct
0a3412b
@KtorZ
Add function to convert UTCTime -> POSIXTime in hydra-plutus
262dfa8 
  And bootstrap the first specs for this package.
@abailly
Update nix cache fqdn
e1faf9f
@ghost ghost marked this pull request as ready for review May 23, 2022 04:26
abailly added 9 commits May 23, 2022 12:11
@abailly
Fix compilation errors following change in OnCloseTx
f6e2115
@abailly
Check conversion from plutus time preserves ordering
c22e397
@abailly
Fix values used in QC's cover function
1ebf51a 
The docs are somewhat misleading: This value is a percentage not
expressed as a value between 0 and 1 but between 0 and 100.
@abailly
Handle special case in test for observing OnCloseTx
409da6d
@abailly
Add missing fields in the Log's schema
b76d376
@abailly
Replace the use of DiffTime w/ NominalDiffTime
ff15ebf 
The former takes into account leap seconds and works with
AbsoluteTime, whereas we work with UTCTime and really care about
actual passing of time.
@abailly
Simplify computation of remaining contestation period
fc319a7
@abailly
Fix time transformation and remaining deadline
cbecdd4
@abailly
Add a small margin to remaining period to prevent tx to fail
6384a99 
also compute wait time in ETE test with some ridiculous formula taking
into account contestation period, close grace time  and slot length!
@ghost ghost requested review from KtorZ and ch1bo May 23, 2022 15:44
@github-actions
Copy link

github-actions bot commented May 23, 2022 •
edited
Loading

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2022-05-24 08:09:18.464048238 UTC
Max. memory units 14000000.00
Max. CPU units 10000000000.00
Max. tx size (kB) 16384

Cost of Init Transaction

Parties Tx size % max Mem % max CPU
1 4737 12.52 6.89
2 4936 16.13 8.88
3 5136 20.97 11.62
5 5537 29.89 16.64
10 6537 45.92 25.39
30 10540 91.44 48.97
45 13540 99.87 50.94

Cost of Commit Transaction

Currently only one UTxO per commit allowed (this is about to change soon)

UTxO Tx size % max Mem % max CPU
1 5859 17.92 8.78

Cost of CollectCom Transaction

Parties Tx size % max Mem % max CPU
1 13908 22.66 12.35
2 14097 38.03 20.82
3 14744 64.36 35.62
4 14831 81.26 45.03

Cost of Close Transaction

Parties Tx size % max Mem % max CPU
1 9226 7.72 4.10
2 9746 13.10 6.99
3 9894 13.63 7.25
5 10119 14.22 7.56
10 11415 26.55 14.21
30 15180 57.00 30.59
47 15448 68.01 35.89

Cost of Abort Transaction

Parties Tx size % max Mem % max CPU

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

UTxO Tx size % max Mem % max CPU
2 13269 11.36 6.58
3 13370 14.04 8.14
5 13372 14.69 8.46
60 15353 99.42 57.23

@github-actions
Copy link

github-actions bot commented May 23, 2022 •
edited
Loading

Unit Test Results

    5 files  ±0    83 suites   - 1   7m 32s ⏱️ +46s
221 tests  - 1  219 ✔️  - 1  2 💤 ±0  0 ❌ ±0 

Results for commit 76be788. ± Comparison against base commit 7ebee87.

This pull request removes 1 test. 
Hydra.Chain.Direct.Tx/fanoutTx ‑ validates

♻️ This comment has been updated with latest results.

@abailly
Simplify property for comparing time
76be788 
expecting 1/3rd of each Ordering ctor from randomly generated values does not make sense
as EQ is much likely to appear than the other ones.
@ghost ghost merged commit 95be983 into master May 24, 2022
@ghost ghost deleted the ensemble/192/fanout-deadline branch May 24, 2022 08:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ Awaiting requested review from KtorZ

@ch1bo ch1bo Awaiting requested review from ch1bo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fanout should only be postable after contestation deadline
3 participants
@abailly @ch1bo @KtorZ