Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialog lens in hydra-tui #1025

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix dialog lens in hydra-tui #1025

merged 1 commit into from
Aug 17, 2023

Conversation

ch1bo
Copy link
Member

@ch1bo ch1bo commented Aug 17, 2023

Selecting recipients and UTxO to spend was broken due to the use of 'const' which yielded always the same entry in the list.


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

Selecting recipients and UTxO to spend was broken due to the use of
'const' which yielded always the same entry in the list.
@ch1bo ch1bo requested review from locallycompact, pgrange, v0d1ch, a user and ffakenz August 17, 2023 14:01
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Test Results

358 tests  ±0   353 ✔️ ±0   15m 44s ⏱️ -52s
119 suites ±0       5 💤 ±0 
    6 files   ±0       0 ±0 

Results for commit 62e2241. ± Comparison against base commit 62a1afc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2023-08-17 14:19:53.685689938 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 3ffaf6b87df35cb01a52eb23032b8f0b1a2a3ad3acf0930abc9c833a 4150
νCommit e4c32d6dc83b2917aa7805571f30437ad98b6d20d821d34d45943755 2093
νHead 8508839dfce39b6be65c018ce124ab549238e1b2ed08fb6588e5601f 8799
μHead 7e939052f278f7721cb1f98c3f2ca646827df9314a7e0d0168765b49* 4055
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4652 11.30 4.48 0.48
2 4853 13.55 5.36 0.51
3 5059 15.36 6.05 0.54
5 5469 19.30 7.57 0.60
10 6494 29.41 11.48 0.76
45 13671 99.78 38.66 1.84

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 599 12.67 4.97 0.31
2 784 16.49 6.69 0.37
3 975 20.28 8.39 0.42
5 1348 28.55 12.04 0.53
10 2278 51.44 21.99 0.82
18 3783 95.35 40.55 1.38

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 815 24.71 9.81 0.46
2 114 1136 36.80 14.77 0.60
3 170 1456 51.77 20.95 0.78
4 228 1785 68.99 28.05 0.99
5 284 2097 94.20 38.23 1.28

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 685 17.67 8.24 0.38
2 852 18.62 9.33 0.41
3 955 18.59 8.49 0.40
5 1182 20.99 9.74 0.44
10 2664 33.01 22.36 0.70
50 10697 94.61 80.27 1.96

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 721 22.64 10.12 0.44
2 937 24.65 11.80 0.48
3 1164 27.04 13.63 0.52
5 1565 29.56 16.18 0.57
10 2505 38.36 23.70 0.74
43 9222 99.23 75.70 1.90

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4908 21.48 9.25 0.61
2 5047 31.41 13.41 0.72
3 5756 54.27 23.76 1.01
4 6195 76.09 33.37 1.28

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4667 8.62 3.63 0.45
5 1 56 4706 10.10 4.49 0.47
5 5 284 4851 15.61 7.80 0.55
5 10 569 5031 22.17 11.79 0.64
5 20 1138 5389 35.29 19.78 0.82
5 30 1710 5754 48.16 27.66 0.99
5 40 2276 6113 61.30 35.66 1.17
5 50 2843 6467 74.44 43.66 1.35
5 69 3929 7157 99.68 58.99 1.70

End-To-End Benchmark Results

This page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest master code.

Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes.

Generated at 2023-08-17 14:10:08.317646055 UTC

3-nodes Scenario

A rather typical setup, with 3 nodes forming a Hydra head.

Number of nodes 3
Number of txs 900
Avg. Confirmation Time (ms) 112.607008257
P99 317.11404624ms
P95 240.64055069999998ms
P50 100.817262ms
Number of Invalid txs 0

Baseline Scenario

This scenario represents a minimal case and as such is a good baseline against which to assess the overhead introduced by more complex setups. There is a single hydra-node d with a single client submitting single input and single output transactions with a constant UTxO set of 1.

Number of nodes 1
Number of txs 300
Avg. Confirmation Time (ms) 6.269266930
P99 20.434709769999973ms
P95 13.397158500000007ms
P50 4.490306ms
Number of Invalid txs 0

@ch1bo ch1bo merged commit 54db226 into master Aug 17, 2023
@ch1bo ch1bo deleted the fix-tui-dialogs branch August 17, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants